Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1048333003: Set resScale on stroker when stroking path on gpu. (Closed)

Created:
5 years, 8 months ago by egdaniel
Modified:
5 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Set resScale on stroker when stroking path on gpu. BUG=skia:3686 Committed: https://skia.googlesource.com/skia/+/f103cd85392e30d2a534a3a62a034e79abff2d4f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Inline setter #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M include/core/SkStrokeRec.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
5 years, 8 months ago (2015-04-13 16:02:30 UTC) #2
reed1
lgtm w/ nit about inlining the impl https://codereview.chromium.org/1048333003/diff/1/include/core/SkStrokeRec.h File include/core/SkStrokeRec.h (right): https://codereview.chromium.org/1048333003/diff/1/include/core/SkStrokeRec.h#newcode67 include/core/SkStrokeRec.h:67: void setResScale(SkScalar ...
5 years, 8 months ago (2015-04-13 17:10:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048333003/40001
5 years, 8 months ago (2015-04-13 19:59:12 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 20:06:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f103cd85392e30d2a534a3a62a034e79abff2d4f

Powered by Google App Engine
This is Rietveld 408576698