android_webview/android_webview.gyp - Issue 104833006: Switch ContentSettingsObserver to be a RenderFrameObserver instead of a RenderViewObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/android_webview.gyp

Issue 104833006: Switch ContentSettingsObserver to be a RenderFrameObserver instead of a RenderViewObserver (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/android_webview.gyp

===================================================================

--- android_webview/android_webview.gyp (revision 240362)

+++ android_webview/android_webview.gyp (working copy)

@@ -210,6 +210,8 @@

'renderer/aw_content_renderer_client.h',

'renderer/aw_key_systems.cc',

'renderer/aw_key_systems.h',

+ 'renderer/aw_permission_client.cc',

+ 'renderer/aw_permission_client.h',

mkosiba (inactive) 2013/12/16 10:18:01 I think you forgot to add these to the CL

jam 2013/12/16 18:52:31 yep, thanks I've fixed that now. I wasn't able to

'renderer/aw_render_process_observer.cc',

'renderer/aw_render_process_observer.h',

'renderer/aw_render_view_ext.cc',

« no previous file with comments | « no previous file | android_webview/renderer/aw_content_renderer_client.h » ('j') | no next file with comments »