content/browser/frame_host/navigation_controller_delegate.h - Issue 104833006: Switch ContentSettingsObserver to be a RenderFrameObserver instead of a RenderViewObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 104833006: Switch ContentSettingsObserver to be a RenderFrameObserver instead of a RenderViewObserver (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | content/browser/frame_host/render_frame_host_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_delegate.h

===================================================================

--- content/browser/frame_host/navigation_controller_delegate.h (revision 240912)

+++ content/browser/frame_host/navigation_controller_delegate.h (working copy)

@@ -16,6 +16,7 @@

struct NativeWebKeyboardEvent;

class InterstitialPage;

class InterstitialPageImpl;

+class RenderFrameHost;

class RenderViewHost;

class SiteInstance;

class WebContents;

@@ -64,8 +65,8 @@

// Methods needed by InterstitialPageImpl.

virtual bool IsHidden() = 0;

- virtual void RenderViewForInterstitialPageCreated(

- RenderViewHost* render_view_host) = 0;

+ virtual void RenderFrameForInterstitialPageCreated(

+ RenderFrameHost* render_frame_host) = 0;

virtual void AttachInterstitialPage(

InterstitialPageImpl* interstitial_page) = 0;

virtual void DetachInterstitialPage() = 0;