Switch ContentSettingsObserver to be a RenderFrameObserver instead of a RenderViewObserver

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 44 matching lines @@
 
   virtual ~RenderFrameImpl();
 
   // TODO(jam): this is a temporary getter until all the code is transitioned
   // to using RenderFrame instead of RenderView.
   RenderViewImpl* render_view() { return render_view_; }
 
   // Returns the RenderWidget associated with this frame.
   RenderWidget* GetRenderWidget();
 
+  // Called by RenderView right after creating this object when the
+  // blink::WebFrame has been created.
+  void MainWebFrameCreated(blink::WebFrame* frame);

[nasko, 2013/12/16 19:47:37]

Will we need this longer term? If not, might be useful to put a TODO to ensure
we don't miss it later on.

[jam, 2013/12/16 20:26:48]

this will be needed because when the RenderFrame is created, we don't have a
WebFrame yet. So it needs to be told so that it can tell its observers. this is
independent of whether a RF is per WF or per many.

+
 #if defined(ENABLE_PLUGINS)
   // Notification that a PPAPI plugin has been created.
   void PepperPluginCreated(RendererPpapiHost* host);
 
   // Indicates that the given instance has been created.
   void PepperInstanceCreated(PepperPluginInstanceImpl* instance);
 
   // Indicates that the given instance is being destroyed. This is called from
   // the destructor, so it's important that the instance is not dereferenced
   // from this call.
@@ skipping 262 matching lines @@
 
   // All the registered observers.
   ObserverList<RenderFrameObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_