Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Issue 1048323003: Allows the findbar to respond to "Paste and Match Style" menu commands. (Closed)

Created:
5 years, 8 months ago by rohitrao (ping after 24h)
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allows the findbar to respond to "Paste and Match Style" menu commands. BUG=477311 TEST=Open the find bar with Cmd-F. The "Edit -> Paste and Match Style" menu item should not be greyed out and should paste properly when chosen. Committed: https://crrev.com/198cc58f84731e50a12b434c2401c821f0958e36 Cr-Commit-Position: refs/heads/master@{#325256}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field.mm View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rohitrao (ping after 24h)
5 years, 8 months ago (2015-04-15 15:03:39 UTC) #2
Robert Sesek
LGTM w/ nit https://codereview.chromium.org/1048323003/diff/1/chrome/browser/ui/cocoa/find_bar/find_bar_text_field.mm File chrome/browser/ui/cocoa/find_bar/find_bar_text_field.mm (right): https://codereview.chromium.org/1048323003/diff/1/chrome/browser/ui/cocoa/find_bar/find_bar_text_field.mm#newcode58 chrome/browser/ui/cocoa/find_bar/find_bar_text_field.mm:58: nit: extra blank line
5 years, 8 months ago (2015-04-15 15:15:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048323003/20001
5 years, 8 months ago (2015-04-15 15:18:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 16:20:44 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 16:22:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/198cc58f84731e50a12b434c2401c821f0958e36
Cr-Commit-Position: refs/heads/master@{#325256}

Powered by Google App Engine
This is Rietveld 408576698