Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1048313003: Revert of bluetooth: Move requestDevice() to UI thread. (Closed)

Created:
5 years, 8 months ago by falken
Modified:
5 years, 8 months ago
Reviewers:
scheib, ortuno
CC:
chromium-reviews, darin-cc_chromium.org, jam, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Move requestDevice() to UI thread. (patchset #2 id:20001 of https://codereview.chromium.org/1058373002/) Reason for revert: The layout test bluetooth/requestDevice.html became flaky after this patch landed. Flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=bluetooth%2FrequestDevice.html Example failure link: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/35097 Failure output: This is a testharness.js-based test. PASS window.testRunner is required for the following tests. PASS Reject with NotFoundError. FAIL Reject with SecurityError. assert_unreached: Mock was set to reject. Reached unreachable code PASS Mock will resolve. Harness: the test ran to completion. Original issue's description: > bluetooth: Move requestDevice() to UI thread. > > BluetoothAdapter is not thread safe, this change moves the requestDevice() call to it onto the UI thread. > > BUG=420284 > > Committed: https://crrev.com/8a72921779123fbd7a7f756f9683f4df8944ea9d > Cr-Commit-Position: refs/heads/master@{#323919} TBR=scheib@chromium.org,ortuno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420284 Committed: https://crrev.com/fd09a4f28689b339fb3ef5e8cc3e47cdc0ae9944 Cr-Commit-Position: refs/heads/master@{#323997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of bluetooth: Move requestDevice() to UI thread.
5 years, 8 months ago (2015-04-07 01:20:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048313003/1
5 years, 8 months ago (2015-04-07 01:20:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 01:21:46 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 01:22:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd09a4f28689b339fb3ef5e8cc3e47cdc0ae9944
Cr-Commit-Position: refs/heads/master@{#323997}

Powered by Google App Engine
This is Rietveld 408576698