Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1048303004: Added new BypassedBytes.Current histograms. (Closed)

Created:
5 years, 8 months ago by sclittle
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added new BypassedBytes.Current histograms. Added new histograms to break down Current bypasses (i.e. "Chrome-Proxy: block-once") by audio/video content types, as well as "content-type: application/octet-stream". BUG=473763 Committed: https://crrev.com/6fef54c59bcb8192521b0ba0c94c9230e7a93520 Cr-Commit-Position: refs/heads/master@{#324075}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -29 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc View 2 chunks +49 lines, -18 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc View 2 chunks +29 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
sclittle
PTAL
5 years, 8 months ago (2015-04-03 21:04:30 UTC) #2
bengr
lgtm, modulo nit. Please be more specific in the CL description. https://codereview.chromium.org/1048303004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc (right): ...
5 years, 8 months ago (2015-04-03 22:09:55 UTC) #3
sclittle
https://codereview.chromium.org/1048303004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc (right): https://codereview.chromium.org/1048303004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc#newcode775 components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:775: {"DataReductionProxy.BypassedBytes.Current", "HTTP/1.1 200 OK\r\n\r\n"}, On 2015/04/03 22:09:55, bengr wrote: ...
5 years, 8 months ago (2015-04-03 22:22:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048303004/20001
5 years, 8 months ago (2015-04-03 22:23:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54167)
5 years, 8 months ago (2015-04-03 22:35:59 UTC) #9
sclittle
asvitkine: histograms.xml Thanks in advance!
5 years, 8 months ago (2015-04-03 23:55:07 UTC) #11
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-07 15:31:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048303004/20001
5 years, 8 months ago (2015-04-07 17:30:16 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 18:29:19 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:30:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fef54c59bcb8192521b0ba0c94c9230e7a93520
Cr-Commit-Position: refs/heads/master@{#324075}

Powered by Google App Engine
This is Rietveld 408576698