Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1048223002: Add DisplayItemListPictureRecorder (Closed)

Created:
5 years, 8 months ago by Xianzhu
Modified:
5 years, 8 months ago
Reviewers:
chrishtr, f(malita)
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add DisplayItemListPictureRecorder This simplifies code that records paintings into a SkPicture. This is a preparation CL before I change the signature of DisplayItemList::replay().

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -27 lines) Patch
M Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 3 chunks +4 lines, -9 lines 1 comment Download
M Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 1 3 chunks +4 lines, -9 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 1 3 chunks +4 lines, -9 lines 0 comments Download
A Source/platform/graphics/paint/DisplayItemListPictureRecorder.h View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Xianzhu
5 years, 8 months ago (2015-03-31 21:33:15 UTC) #2
chrishtr
https://codereview.chromium.org/1048223002/diff/20001/Source/core/layout/svg/LayoutSVGResourceClipper.cpp File Source/core/layout/svg/LayoutSVGResourceClipper.cpp (right): https://codereview.chromium.org/1048223002/diff/20001/Source/core/layout/svg/LayoutSVGResourceClipper.cpp#newcode157 Source/core/layout/svg/LayoutSVGResourceClipper.cpp:157: DisplayItemListPictureRecorder pictureRecorder(bounds); This is getting a little out of ...
5 years, 8 months ago (2015-03-31 21:52:51 UTC) #3
Xianzhu
5 years, 8 months ago (2015-04-01 02:03:48 UTC) #4 
Seems not necessary. Closing.

Powered by Google App Engine
This is Rietveld 408576698