src/runtime/runtime-observe.cc - Issue 1048213002: Add a UseCounter for Object.observe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-observe.cc

Issue 1048213002: Add a UseCounter for Object.observe (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use HandleScope instead of SealHandleScope in %GetObservationState Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-observe.cc

diff --git a/src/runtime/runtime-observe.cc b/src/runtime/runtime-observe.cc

index 211922c5b78fad1bcc73f6f4804b676fd62ca0e9..a942645236f76e59e9e5be95aa09f3b815f560f0 100644

--- a/src/runtime/runtime-observe.cc

+++ b/src/runtime/runtime-observe.cc

@@ -88,8 +88,9 @@ RUNTIME_FUNCTION(Runtime_DeliverObservationChangeRecords) {

RUNTIME_FUNCTION(Runtime_GetObservationState) {

- SealHandleScope shs(isolate);

+ HandleScope scope(isolate);

DCHECK(args.length() == 0);

+ isolate->CountUsage(v8::Isolate::kObjectObserve);

return isolate->heap()->observation_state();

}

« no previous file with comments | « include/v8.h ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »