Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1048213002: Add a UseCounter for Object.observe (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr., rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a UseCounter for Object.observe It triggers once per context that calls observe (or attempts to access any observation metadata, e.g. through Object.getNotifier). Committed: https://crrev.com/729b85ae8678ebd998a0e5f254817683198d0610 Cr-Commit-Position: refs/heads/master@{#27557}

Patch Set 1 #

Patch Set 2 : Use HandleScope instead of SealHandleScope in %GetObservationState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-observe.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
adamk
5 years, 8 months ago (2015-03-31 19:05:52 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-03-31 19:17:12 UTC) #3
adamk
So this patch is fine by itself, but we'll need something fancier on the Blink ...
5 years, 8 months ago (2015-03-31 22:22:25 UTC) #4
adamk
I misdiagnosed the problem, it was simply a lack of a HandleScope that was causing ...
5 years, 8 months ago (2015-03-31 22:29:56 UTC) #5
arv (Not doing code reviews)
Still LGTM
5 years, 8 months ago (2015-03-31 22:38:27 UTC) #6
adamk
On 2015/03/31 22:38:27, arv wrote: > Still LGTM Hmm, I think this HandleScope is actually ...
5 years, 8 months ago (2015-03-31 22:41:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048213002/20001
5 years, 8 months ago (2015-03-31 22:42:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 23:03:13 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 23:03:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/729b85ae8678ebd998a0e5f254817683198d0610
Cr-Commit-Position: refs/heads/master@{#27557}

Powered by Google App Engine
This is Rietveld 408576698