Issue 1048133002: [bindings] Remove custom bindings required for Location.valueOf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1048133002: [bindings] Remove custom bindings required for Location.valueOf (Closed)

Created:
5 years, 8 months ago by vivekg_samsung

Modified:
5 years, 8 months ago

Reviewers:
haraken, vivekg, Jens Widell

CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, Inactive, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

[bindings] Remove custom bindings required for Location.valueOf Use extended idl attribute, CallWith=ThisValue, to remove the usage of custom binding for Location.valueOf method. BUG=345519 R=haraken@chromium.org, jl@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192841

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -48 lines)			Patch
D	Source/bindings/core/v8/custom/V8LocationCustom.cpp	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	Source/bindings/core/v8/custom/custom.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/frame/Location.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/frame/Location.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048133002/1

5 years, 8 months ago (2015-03-31 15:33:14 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 16:32:25 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192841