Source/platform/fonts/harfbuzz/HarfBuzzShaper.h - Issue 104813005: Explicitly set text direction for TextRuns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

Issue 104813005: Explicitly set text direction for TextRuns (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

index a46199fdb148c47c172f34aac36cbfd5b2c2e4a3..461e2c9a3124eabd963011c05742392cb3af8a68 100644

--- a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

+++ b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

@@ -123,7 +123,7 @@ private:

void setFontFeatures();

bool collectHarfBuzzRuns();

- bool shapeHarfBuzzRuns(bool shouldSetDirection);

+ bool shapeHarfBuzzRuns();

bool fillGlyphBuffer(GlyphBuffer*);

void fillGlyphBufferFromHarfBuzzRun(GlyphBuffer*, HarfBuzzRun*, FloatPoint& firstOffsetOfNextRun);

void setGlyphPositionsForHarfBuzzRun(HarfBuzzRun*, hb_buffer_t*);