Source/core/rendering/RenderCombineText.h - Issue 104813005: Explicitly set text direction for TextRuns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderCombineText.h

Issue 104813005: Explicitly set text direction for TextRuns (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use BidiResolver in RenderText Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderBlockLineLayout.cpp ('K') | « Source/core/rendering/RenderBlockLineLayout.cpp ('k') | Source/core/rendering/RenderCombineText.cpp » ('j') | Source/core/rendering/RenderText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderCombineText.h

diff --git a/Source/core/rendering/RenderCombineText.h b/Source/core/rendering/RenderCombineText.h

index ce196d4c360e8d3675b8f212241610fb443f3255..d2731671d71fd5b61cf84586e70fdfa0bd2e9be4 100644

--- a/Source/core/rendering/RenderCombineText.h

+++ b/Source/core/rendering/RenderCombineText.h

@@ -39,7 +39,7 @@ public:

private:

virtual bool isCombineText() const { return true; }

- virtual float width(unsigned from, unsigned length, const Font&, float xPosition, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;

+ virtual float width(unsigned from, unsigned length, const Font&, float xPosition, TextDirection, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;

virtual const char* renderName() const { return "RenderCombineText"; }

virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);

virtual void setTextInternal(PassRefPtr<StringImpl>);