Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 1048103003: Add an emacs mode for gn files. (Closed)

Created:
5 years, 8 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an emacs mode for gn files. BUG=none Committed: https://crrev.com/3074045136e6a83a08de513e847c68ccfb71e4dd Cr-Commit-Position: refs/heads/master@{#323075}

Patch Set 1 #

Patch Set 2 : Moved file + gitignore the *.elc spam. #

Total comments: 3

Patch Set 3 : thakis comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A tools/gn/misc/emacs/.gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/misc/emacs/gn.el View 1 2 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Elliot Glaysher
Hi Nico, you appear to be one of the few people who have reviewed elisp ...
5 years, 8 months ago (2015-03-31 17:44:45 UTC) #2
tfarina
Could you add this in tools/gn/misc/emacs instead?
5 years, 8 months ago (2015-03-31 17:46:27 UTC) #3
Nico
seems ok. i don't use emacs and don't know elisp well (i have some scheme ...
5 years, 8 months ago (2015-03-31 18:01:35 UTC) #4
tfarina
thanks, I'm happy with the new location. lgtm
5 years, 8 months ago (2015-03-31 18:05:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048103003/40001
5 years, 8 months ago (2015-03-31 18:09:10 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-31 18:29:23 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 18:29:54 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3074045136e6a83a08de513e847c68ccfb71e4dd
Cr-Commit-Position: refs/heads/master@{#323075}

Powered by Google App Engine
This is Rietveld 408576698