Added %_Likely/%_Unlikely intrinsics (special cases of GCC's __builin_expect).

test/unittests/compiler/js-intrinsic-lowering-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
+#include "src/compiler/diamond.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-intrinsic-lowering.h"
 #include "src/compiler/js-operator.h"
 #include "test/unittests/compiler/graph-unittest.h"
 #include "test/unittests/compiler/node-test-utils.h"
 #include "testing/gmock-support.h"
 
+
 using testing::_;
 using testing::AllOf;
 using testing::BitEq;
 using testing::Capture;
 using testing::CaptureEq;
 
 
 namespace v8 {
 namespace internal {
 namespace compiler {
@@ skipping 213 matching lines @@
   Reduction const r = Reduce(graph()->NewNode(
       javascript()->CallRuntime(Runtime::kInlineJSValueGetValue, 1), input,
       context, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
               IsLoadField(AccessBuilder::ForValue(), input, effect, control));
 }
 
 
 // -----------------------------------------------------------------------------
+// %_Likely
+
+TEST_F(JSIntrinsicLoweringTest, Likely) {
+  Node* const input = Parameter(0);
+  Node* const context = Parameter(1);
+  Node* const effect = graph()->start();
+  Node* const control = graph()->start();
+  Node* const likely =
+      graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineLikely, 1),
+                       input, context, effect, control);
+  Node* const to_boolean =
+      graph()->NewNode(javascript()->ToBoolean(), likely, context);
+  Diamond d(graph(), common(), to_boolean);
+  graph()->SetEnd(graph()->NewNode(common()->End(), d.merge));
+
+  ASSERT_TRUE(BranchHint::kNone == BranchHintOf(d.branch->op()));

[Michael Starzinger, 2015/03/31 12:49:03]

nit: ASSERT_EQ

[Sven Panne, 2015/03/31 13:01:34]

Done.

+  Reduction const r = Reduce(likely);
+  ASSERT_TRUE(r.Changed());
+  ASSERT_TRUE(input->op()->Equals(r.replacement()->op()));

[Michael Starzinger, 2015/03/31 12:49:03]

nit: EXPECT_THAT(r.replacement(), input)

[Sven Panne, 2015/03/31 13:01:34]

Done.

+  ASSERT_TRUE(BranchHint::kTrue == BranchHintOf(d.branch->op()));

[Michael Starzinger, 2015/03/31 12:49:03]

nit: EXPECT_EQ

[Sven Panne, 2015/03/31 13:01:35]

Done.

+}
+
+
+// -----------------------------------------------------------------------------
 // %_MathFloor
 
 
 TEST_F(JSIntrinsicLoweringTest, InlineMathFloor) {
   Node* const input = Parameter(0);
   Node* const context = Parameter(1);
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineMathFloor, 1),
@@ skipping 50 matching lines @@
   Node* const control = graph()->start();
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineMathClz32, 1),
                        input, context, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsWord32Clz(input));
 }
 
 
 // -----------------------------------------------------------------------------
+// %_Unlikely
+
+TEST_F(JSIntrinsicLoweringTest, Unlikely) {
+  Node* const input = Parameter(0);
+  Node* const context = Parameter(1);
+  Node* const effect = graph()->start();
+  Node* const control = graph()->start();
+  Node* const unlikely =
+      graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineUnlikely, 1),
+                       input, context, effect, control);
+  Node* const to_boolean =
+      graph()->NewNode(javascript()->ToBoolean(), unlikely, context);
+  Diamond d(graph(), common(), to_boolean);
+  graph()->SetEnd(graph()->NewNode(common()->End(), d.merge));
+
+  ASSERT_TRUE(BranchHint::kNone == BranchHintOf(d.branch->op()));

[Michael Starzinger, 2015/03/31 12:49:03]

nit: Same as the three comments above.

+  Reduction const r = Reduce(unlikely);
+  ASSERT_TRUE(r.Changed());
+  ASSERT_TRUE(input->op()->Equals(r.replacement()->op()));
+  ASSERT_TRUE(BranchHint::kFalse == BranchHintOf(d.branch->op()));
+}
+
+
+// -----------------------------------------------------------------------------
 // %_ValueOf
 
 
 TEST_F(JSIntrinsicLoweringTest, InlineValueOf) {
   Node* const input = Parameter(0);
   Node* const context = Parameter(1);
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineValueOf, 1),
@@ skipping 24 matching lines @@
                             CaptureEq(&if_false0)))))),
           IsMerge(
               IsIfTrue(AllOf(CaptureEq(&branch0),
                              IsBranch(IsObjectIsSmi(input), control))),
               AllOf(CaptureEq(&if_false0), IsIfFalse(CaptureEq(&branch0))))));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8