Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/resources/feedback/js/event_handler.js

Issue 1048033004: Add Chrome receiver app IDs to the feedback whitelist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @type {number} 6 * @type {number}
7 * @const 7 * @const
8 */ 8 */
9 var FEEDBACK_WIDTH = 500; 9 var FEEDBACK_WIDTH = 500;
10 /** 10 /**
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 'A74A4D44C7CFCD8844830E6140C8D763E12DD8F3', // Hangouts Extension 49 'A74A4D44C7CFCD8844830E6140C8D763E12DD8F3', // Hangouts Extension
50 '312745D9BF916161191143F6490085EEA0434997', // Hangouts Extension 50 '312745D9BF916161191143F6490085EEA0434997', // Hangouts Extension
51 '53041A2FA309EECED01FFC751E7399186E860B2C', // Hangouts Extension 51 '53041A2FA309EECED01FFC751E7399186E860B2C', // Hangouts Extension
52 '0F42756099D914A026DADFA182871C015735DD95', // Hangouts Extension 52 '0F42756099D914A026DADFA182871C015735DD95', // Hangouts Extension
53 '1B7734733E207CCE5C33BFAA544CA89634BF881F', // GLS nightly 53 '1B7734733E207CCE5C33BFAA544CA89634BF881F', // GLS nightly
54 'E2ACA3D943A3C96310523BCDFD8C3AF68387E6B7', // GLS stable 54 'E2ACA3D943A3C96310523BCDFD8C3AF68387E6B7', // GLS stable
55 '11B478CEC461C766A2DC1E5BEEB7970AE06DC9C2', // http://crbug.com/463552 55 '11B478CEC461C766A2DC1E5BEEB7970AE06DC9C2', // http://crbug.com/463552
56 '0EFB879311E9EFBB7C45251F89EC655711B1F6ED', // http://crbug.com/463552 56 '0EFB879311E9EFBB7C45251F89EC655711B1F6ED', // http://crbug.com/463552
57 '9193D3A51E2FE33B496CDA53EA330423166E7F02', // http://crbug.com/463552 57 '9193D3A51E2FE33B496CDA53EA330423166E7F02', // http://crbug.com/463552
58 'F9119B8B18C7C82B51E7BC6FF816B694F2EC3E89', // http://crbug.com/463552 58 'F9119B8B18C7C82B51E7BC6FF816B694F2EC3E89', // http://crbug.com/463552
59 '676A08383D875E51CE4C2308D875AE77199F1413', // Chrome Receiver App Dev
rkc 2015/04/03 22:49:33 Please put the bug numbers here (as above). The ap
Alyssa 2015/04/06 20:00:25 Done.
60 '869A23E11B308AF45A68CC386C36AADA4BE44A01', // Chrome Receiver App Canary
59 ]; 61 ];
60 62
61 63
62 /** 64 /**
63 * Function to determine whether or not a given extension id is whitelisted to 65 * Function to determine whether or not a given extension id is whitelisted to
64 * invoke the feedback UI. If the extension is whitelisted, the callback to 66 * invoke the feedback UI. If the extension is whitelisted, the callback to
65 * start the Feedback UI will be called. 67 * start the Feedback UI will be called.
66 * @param {string} id the id of the sender extension. 68 * @param {string} id the id of the sender extension.
67 * @param {Function} startFeedbackCallback The callback function that will 69 * @param {Function} startFeedbackCallback The callback function that will
68 * will start the feedback UI. 70 * will start the feedback UI.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 width: FEEDBACK_WIDTH, 124 width: FEEDBACK_WIDTH,
123 height: FEEDBACK_HEIGHT, 125 height: FEEDBACK_HEIGHT,
124 hidden: true, 126 hidden: true,
125 resizable: false }, 127 resizable: false },
126 function(appWindow) {}); 128 function(appWindow) {});
127 } 129 }
128 130
129 chrome.runtime.onMessage.addListener(feedbackReadyHandler); 131 chrome.runtime.onMessage.addListener(feedbackReadyHandler);
130 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler); 132 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler);
131 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI); 133 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698