Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1048033004: Add Chrome receiver app IDs to the feedback whitelist. (Closed)

Created:
5 years, 8 months ago by Alyssa
Modified:
5 years, 8 months ago
Reviewers:
rkc
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Chrome receiver app IDs to the feedback whitelist. BUG=473845 Committed: https://crrev.com/1e1280f0452a5d19721c718ce32f71ef5d692533 Cr-Commit-Position: refs/heads/master@{#323969}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Point to bug instead. #

Patch Set 3 : synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/feedback/js/event_handler.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
rkc
https://codereview.chromium.org/1048033004/diff/1/chrome/browser/resources/feedback/js/event_handler.js File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/1048033004/diff/1/chrome/browser/resources/feedback/js/event_handler.js#newcode59 chrome/browser/resources/feedback/js/event_handler.js:59: '676A08383D875E51CE4C2308D875AE77199F1413', // Chrome Receiver App Dev Please put the ...
5 years, 8 months ago (2015-04-03 22:49:33 UTC) #2
Alyssa
Thanks! https://codereview.chromium.org/1048033004/diff/1/chrome/browser/resources/feedback/js/event_handler.js File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/1048033004/diff/1/chrome/browser/resources/feedback/js/event_handler.js#newcode59 chrome/browser/resources/feedback/js/event_handler.js:59: '676A08383D875E51CE4C2308D875AE77199F1413', // Chrome Receiver App Dev On 2015/04/03 ...
5 years, 8 months ago (2015-04-06 20:00:25 UTC) #3
rkc
lgtm
5 years, 8 months ago (2015-04-06 20:15:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048033004/20001
5 years, 8 months ago (2015-04-06 21:02:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/12172) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-06 21:06:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048033004/40001
5 years, 8 months ago (2015-04-06 21:37:03 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-06 22:53:16 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 22:55:46 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1e1280f0452a5d19721c718ce32f71ef5d692533
Cr-Commit-Position: refs/heads/master@{#323969}

Powered by Google App Engine
This is Rietveld 408576698