Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 104803002: remove arm_version==5 configuration, since it's no longer supported (Closed)

Created:
7 years ago by Mostyn Bramley-Moore
Modified:
7 years ago
Reviewers:
Nico, digit1
CC:
chromium-reviews
Visibility:
Public.

Description

remove arm_version==5 configuration, since it's no longer supported Since armv5 builds are no longer supported (due to being dropped by V8), let's remove a stray arm_version==5 section from the build configration. BUG=234135 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mostyn Bramley-Moore
@digit1: this was the only remaining non-third_party arm_version==5 config that I could fine.
7 years ago (2013-12-04 15:41:19 UTC) #1
digit1
lgtm, (not an owner). Thanks.
7 years ago (2013-12-04 16:24:17 UTC) #2
Mostyn Bramley-Moore
On 2013/12/04 16:24:17, digit1 wrote: > lgtm, (not an owner). Thanks. I thought all committers ...
7 years ago (2013-12-04 16:26:53 UTC) #3
digit1
You're rigth, my bad, please go ahead :-)
7 years ago (2013-12-04 16:32:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/104803002/1
7 years ago (2013-12-04 16:33:22 UTC) #5
Nico
lgtm Thanks!
7 years ago (2013-12-04 16:47:07 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-04 18:26:13 UTC) #7
Message was sent while issue was closed.
Change committed as 238725

Powered by Google App Engine
This is Rietveld 408576698