Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: LayoutTests/fast/dom/idl-dictionary-unittest.html

Issue 1047993002: bindings: Add validation for enum Sequence or Array (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/idl-dictionary-unittest.html
diff --git a/LayoutTests/fast/dom/idl-dictionary-unittest.html b/LayoutTests/fast/dom/idl-dictionary-unittest.html
index a31e4945b982104983ef129c81dbfc0322bd27b7..e25d5dd24c0896cf114982e129580594ba4c90a7 100644
--- a/LayoutTests/fast/dom/idl-dictionary-unittest.html
+++ b/LayoutTests/fast/dom/idl-dictionary-unittest.html
@@ -28,6 +28,7 @@ if (window.internals && internals.dictionaryTest) {
shouldBeUndefined('dict.elementMember');
shouldBeUndefined('dict.elementOrNullMember');
shouldBeUndefined('dict.enumMember');
+ shouldBeUndefined('dict.enumArrayMember');
shouldBeEqualToString('dict.enumMemberWithDefault', 'foo');
shouldBeUndefined('dict.enumOrNullMember');
shouldBeUndefined('dict.objectMember');
@@ -81,6 +82,7 @@ if (window.internals && internals.dictionaryTest) {
enumMember: 'foo',
enumMemberWithDefault: 'bar',
enumOrNullMember: 'baz',
+ enumArrayMember: ['foo', 'bar', 'baz'],
objectMember: testObject1,
objectOrNullMemberWithDefault: testObject2,
doubleOrStringMember: 3.14,
@@ -106,6 +108,7 @@ if (window.internals && internals.dictionaryTest) {
shouldBeEqualToString('dict.enumMember', 'foo');
shouldBeEqualToString('dict.enumMemberWithDefault', 'bar');
shouldBeEqualToString('dict.enumOrNullMember', 'baz');
+ shouldBe('dict.enumArrayMember', '["foo", "bar", "baz"]');
shouldBe('dict.objectMember', 'testObject1');
shouldBe('dict.objectOrNullMemberWithDefault', 'testObject2');
shouldBe('dict.doubleOrStringMember', '3.14');
@@ -182,6 +185,7 @@ if (window.internals && internals.dictionaryTest) {
debug('Test for setting invalid enum value');
shouldThrow("dictionaryTest.set({enumMember: 'invalid'})");
+ shouldThrow("dictionaryTest.set({enumArrayMember: ['foo', 'invalid', 'baz']})");
debug('');
debug('Test for setting invalid object value');

Powered by Google App Engine
This is Rietveld 408576698