Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp - Issue 1047993002: bindings: Add validation for enum Sequence or Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Issue 1047993002: bindings: Add validation for enum Sequence or Array (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/tests/results/core/V8TestObject.cpp ('K') | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/core/testing/DictionaryTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

diff --git a/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp b/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

index ce85958b6117668f272894090421a464a8fa82f5..ec7de0f80a9d21077924420b5c45f4ee712f6ffa 100644

--- a/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

+++ b/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

@@ -233,9 +233,12 @@ static void partialVoidTestEnumModulesArgMethodMethod(const v8::FunctionCallback

arg = info[0];

if (!arg.prepare())

return;

- String string = arg;

- if (!(string == "EnumModulesValue1" || string == "EnumModulesValue2")) {

- V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("partialVoidTestEnumModulesArgMethod", "TestInterface", "parameter 1 ('" + string + "') is not a valid enum value."));

+ const char* validValues[] = {

+ "EnumModulesValue1",

+ "EnumModulesValue2",

+ };

+ if (!isValidEnum(arg, validValues, 2)) {

+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("partialVoidTestEnumModulesArgMethod", "TestInterface", "parameter 1 is not a valid enum value."));

return;

}