bindings: Add validation for enum Sequence or Array

Source/bindings/tests/results/core/V8TestDictionary.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
 
 #include "config.h"
 #include "V8TestDictionary.h"
 
 #include "bindings/core/v8/ExceptionState.h"
@@ skipping 112 matching lines @@
     if (block.HasCaught()) {
         exceptionState.rethrowV8Exception(block.Exception());
         return;
     }
     if (enumMemberValue.IsEmpty() || enumMemberValue->IsUndefined()) {
         // Do nothing.
     } else {
         V8StringResource<> enumMember = enumMemberValue;
         if (!enumMember.prepare(exceptionState))
             return;
-        String string = enumMember;
-        if (!(string == "" || string == "EnumValue1" || string == "EnumValue2" || string == "EnumValue3")) {
-            exceptionState.throwTypeError("member enumMember ('" + string + "') is not a valid enum value.");
+        static const char* validValues[] = {
+            "",
+            "EnumValue1",
+            "EnumValue2",
+            "EnumValue3",
+        };
+        if (!isValidEnum(enumMember, validValues, WTF_ARRAY_LENGTH(validValues))) {
+            exceptionState.throwTypeError("member enumMember ('" + toCoreString(isolate, enumMemberValue) + "') is not a valid enum value.");
             return;
         }
         impl.setEnumMember(enumMember);
     }
 
+    v8::Local<v8::Value> enumSequenceMemberValue = v8Object->Get(v8String(isolate, "enumSequenceMember"));
+    if (block.HasCaught()) {
+        exceptionState.rethrowV8Exception(block.Exception());
+        return;
+    }
+    if (enumSequenceMemberValue.IsEmpty() || enumSequenceMemberValue->IsUndefined()) {
+        // Do nothing.
+    } else {
+        Vector<String> enumSequenceMember = toImplArray<String>(enumSequenceMemberValue, 0, isolate, exceptionState);
+        if (exceptionState.hadException())
+            return;
+        static const char* validValues[] = {
+            "",
+            "EnumValue1",
+            "EnumValue2",
+            "EnumValue3",
+        };
+        if (!isValidEnum(enumSequenceMember, validValues, WTF_ARRAY_LENGTH(validValues))) {
+            exceptionState.throwTypeError("member enumSequenceMember ('" + toCoreString(isolate, enumSequenceMemberValue) + "') is not a valid enum value.");

[haraken, 2015/04/01 01:27:25]

Shall we move the for loop from isValidEnum to the caller side (although I agree
that it will complicate the template file a bit)? Then we can just print one
String that is judged not to be valid here, instead of all Strings including
valid ones. Also we won't need toCoreString().

What do you think?

+            return;
+        }
+        impl.setEnumSequenceMember(enumSequenceMember);
+    }
+
     v8::Local<v8::Value> eventTargetMemberValue = v8Object->Get(v8String(isolate, "eventTargetMember"));
     if (block.HasCaught()) {
         exceptionState.rethrowV8Exception(block.Exception());
         return;
     }
     if (eventTargetMemberValue.IsEmpty() || eventTargetMemberValue->IsUndefined()) {
         // Do nothing.
     } else {
         EventTarget* eventTargetMember = toEventTarget(isolate, eventTargetMemberValue);
         if (!eventTargetMember && !eventTargetMemberValue->IsNull()) {
@@ skipping 337 matching lines @@
     if (impl.hasElementOrNullMember()) {
         dictionary->Set(v8String(isolate, "elementOrNullMember"), toV8(impl.elementOrNullMember(), creationContext, isolate));
     }
 
     if (impl.hasEnumMember()) {
         dictionary->Set(v8String(isolate, "enumMember"), v8String(isolate, impl.enumMember()));
     } else {
         dictionary->Set(v8String(isolate, "enumMember"), v8String(isolate, String("foo")));
     }
 
+    if (impl.hasEnumSequenceMember()) {
+        dictionary->Set(v8String(isolate, "enumSequenceMember"), toV8(impl.enumSequenceMember(), creationContext, isolate));
+    }
+
     if (impl.hasEventTargetMember()) {
         dictionary->Set(v8String(isolate, "eventTargetMember"), toV8(impl.eventTargetMember(), creationContext, isolate));
     }
 
     if (impl.hasInternalDictionarySequenceMember()) {
         dictionary->Set(v8String(isolate, "internalDictionarySequenceMember"), toV8(impl.internalDictionarySequenceMember(), creationContext, isolate));
     }
 
     if (impl.hasLongMember()) {
         dictionary->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, impl.longMember()));
@@ skipping 82 matching lines @@
 }
 
 TestDictionary NativeValueTraits<TestDictionary>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
 {
     TestDictionary impl;
     V8TestDictionary::toImpl(isolate, value, impl, exceptionState);
     return impl;
 }
 
 } // namespace blink