Notify hotwording extension of microphone state change.

Notify hotwording extension of microphone state change.

This CL notifies the hotwording extension of a microphone state change
by adding a hotwordPrivate.onMicrophoneStateChanged event which triggers
an update of the hotwording state.

It also moves the media device observation from HotwordServiceFactory to
HotwordService.

BUG=461787
TBR=estade@chromium.org

Committed: https://crrev.com/509ce7f973d5755f1b59657325e03f31e6308af0
Cr-Commit-Position: refs/heads/master@{#324024}

[calamity, 2015-03-31 05:57:12]

Patchset #1 (id:1) has been deleted

[calamity, 2015-03-31 05:58:54]

calamity@chromium.org changed reviewers:
+ kcarattini@chromium.org

[calamity, 2015-03-31 06:18:07]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-03-31 06:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047973003/20001

[commit-bot: I haz the power, 2015-03-31 06:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 06:27:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kcarattini, 2015-03-31 23:31:46]

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
(right):

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:110:
EventRouter* router = EventRouter::Get(profile_);
check for a null return value (like the function below)?

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/hotword/manager.js (right):

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/hotword/manager.js:48:
chrome.hotwordPrivate.onMicrophoneStateChanged.addListener(function(enabled) {
How about making the PageAudioManager listen for this event directly? Then you
can setup and remove the listener according to whether sometimes-on is enabled.

[calamity, 2015-04-01 02:36:10]

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
(right):

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:110:
EventRouter* router = EventRouter::Get(profile_);
On 2015/03/31 23:31:46, kcarattini wrote:
> check for a null return value (like the function below)?

Made an overload for SignalEvent.

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/hotword/manager.js (right):

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/hotword/manager.js:48:
chrome.hotwordPrivate.onMicrophoneStateChanged.addListener(function(enabled) {
On 2015/03/31 23:31:46, kcarattini wrote:
> How about making the PageAudioManager listen for this event directly? Then you
> can setup and remove the listener according to whether sometimes-on is
enabled.

Good point. It also means I'm not calling private methods here -.-

[kcarattini, 2015-04-01 05:04:36]

lgtm

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
(right):

https://codereview.chromium.org/1047973003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:110:
EventRouter* router = EventRouter::Get(profile_);
On 2015/04/01 02:36:10, calamity wrote:
> On 2015/03/31 23:31:46, kcarattini wrote:
> > check for a null return value (like the function below)?
> 
> Made an overload for SignalEvent.

Even better.

[calamity, 2015-04-02 02:24:46]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org, estade@chromium.org

[calamity, 2015-04-02 02:24:46]

TBR-ing estade@ for voice_search_ui.cc

+benwells for hotword_private.idl OWNERS.

[Evan Stade, 2015-04-02 20:46:13]

On 2015/04/02 02:24:46, calamity wrote:
> TBR-ing estade@ for voice_search_ui.cc
> 
> +benwells for hotword_private.idl OWNERS.

voice_search_ui.cc lgtm

[benwells, 2015-04-07 06:28:50]

lgtm

[calamity, 2015-04-07 07:44:42]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-04-07 07:44:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
kcarattini@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1047973003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-07 07:45:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047973003/80001

[commit-bot: I haz the power, 2015-04-07 08:33:18]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-07 08:34:10]

Patchset 4 (id:??) landed as
https://crrev.com/509ce7f973d5755f1b59657325e03f31e6308af0
Cr-Commit-Position: refs/heads/master@{#324024}