chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 1047943002: Cache --whitelisted-extension-id in SimpleFeature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 1047943002: Cache --whitelisted-extension-id in SimpleFeature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update tests that fail on memory bots. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/test_extension_environment.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_launcher_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index 316beee3ff15f9dbcca33a367be8d032b6ba7979..28f06880471248875d103411b8e11c4d0206e72f 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -10,6 +10,7 @@

#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "components/crx_file/id_util.h"

#include "extensions/common/extension.h"

+#include "extensions/common/features/simple_feature.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/manifest_handlers/options_page_info.h"

#include "extensions/common/switches.h"

@@ -32,8 +33,7 @@ class InitValueManifestTest : public ChromeManifestTest {

};

TEST_F(InitValueManifestTest, InitFromValueInvalid) {

- base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

- extensions::switches::kWhitelistedExtensionID, kWhitelistID);

+ extensions::SimpleFeature::ScopedWhitelistForTest whitelist(kWhitelistID);

Testcase testcases[] = {

Testcase("init_invalid_version_missing.json", errors::kInvalidVersion),

Testcase("init_invalid_version_invalid.json", errors::kInvalidVersion),