Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: extensions/common/features/simple_feature.h

Issue 1047943002: Cache --whitelisted-extension-id in SimpleFeature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/simple_feature.h
diff --git a/extensions/common/features/simple_feature.h b/extensions/common/features/simple_feature.h
index a5bc27080d0b88a1b64d061c4c1838692ae3e29e..f0c1fd0321bdcaab27a683fc11908670a31cc284 100644
--- a/extensions/common/features/simple_feature.h
+++ b/extensions/common/features/simple_feature.h
@@ -139,6 +139,11 @@ class SimpleFeature : public Feature {
Availability CheckDependencies(
const base::Callback<Availability(const Feature*)>& checker) const;
+ // A singleton copy of the --whitelisted-extension-id so that we don't need to
+ // copy it from the CommandLine each time.
+ static const std::string& whitelisted_extension_id();
+ static std::string* whitelisted_extension_id_;
tapted 2015/03/31 03:26:49 this isn't needed (see below)
jackhou1 2015/03/31 04:37:45 Done.
+
// For clarity and consistency, we handle the default value of each of these
// members the same way: it matches everything. It is up to the higher level
// code that reads Features out of static data to validate that data and set
« no previous file with comments | « no previous file | extensions/common/features/simple_feature.cc » ('j') | extensions/common/features/simple_feature.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698