Cache --whitelisted-extension-id in SimpleFeature.

chrome/browser/extensions/permission_message_combinations_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/test/values_test_util.h"
 #include "chrome/browser/extensions/test_extension_environment.h"
 #include "chrome/common/extensions/permissions/chrome_permission_message_provider.h"
 #include "extensions/common/extension.h"
@@ skipping 11 matching lines @@
  public:
   PermissionMessageCombinationsUnittest()
       : message_provider_(new ChromePermissionMessageProvider()) {}
   ~PermissionMessageCombinationsUnittest() override {}
 
   // Overridden from testing::Test:
   void SetUp() override {
     testing::Test::SetUp();
     // Force creation of ExtensionPrefs before adding extensions.
     env_.GetExtensionPrefs();
+
+    // Whitelist a known extension id so we can test all permissions. This ID
+    // will be used for each test app.
+    base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+        switches::kWhitelistedExtensionID, "ahplfneplbnjcflhdgkkjeiglkkfeelb");
   }
 
  protected:
   // Create and install an app or extension with the given manifest JSON string.
   // Single-quotes in the string will be replaced with double quotes.
   void CreateAndInstall(const std::string& json_manifest) {
-    std::string json_manifest_with_double_quotes = json_manifest;
+    // Add the manifest key so that the ID will be the whitelisted ID.
+    std::string json_manifest_with_key = json_manifest;
+    json_manifest_with_key.replace(json_manifest.length() - 1,
+       json_manifest.length(),
+                ",'key': 'd2hpdGVsaXN0IG1l'}");

[not at google - send to devlin, 2015/04/02 14:31:57]

Voodoo... I suppose the 'd2hpdGVsaXN0IG1l' corresponds with the
"ahplfneplbnjcflhdgkkjeiglkkfeelb" ID?

Another testing improvement would be to add a version of MakeExtension which
takes an ID. All MakeExtension does is construct a manifest to pass to
ExtensionBuilder, which knows how to set the ID manually.

[jackhou1, 2015/04/07 23:46:21]

Done.

+    std::string json_manifest_with_double_quotes = json_manifest_with_key;
     std::replace(json_manifest_with_double_quotes.begin(),
                  json_manifest_with_double_quotes.end(), '\'', '"');
     app_ = env_.MakeExtension(
         *base::test::ParseJson(json_manifest_with_double_quotes));
-    // Add the app to any whitelists so we can test all permissions.
-    base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-        switches::kWhitelistedExtensionID, app_->id());
   }
 
   // Checks whether the currently installed app or extension produces the given
   // permission messages. Call this after installing an app with the expected
   // permission messages. The messages are tested for existence in any order.
   testing::AssertionResult CheckManifestProducesPermissions() {
     return VerifyNoPermissionMessages(app_->permissions_data());
   }
   testing::AssertionResult CheckManifestProducesPermissions(
       const std::string& expected_message_1) {
@@ skipping 1107 matching lines @@
 // TODO(sashab): Add a test that ensures that all permissions that can generate
 // a coalesced message can also generate a message on their own (i.e. ensure
 // that no permissions only modify other permissions).
 
 // TODO(sashab): Add a test for every permission message combination that can
 // generate a message.
 
 // TODO(aboxhall): Add tests for the automation API permission messages.
 
 }  // namespace extensions