Cache --whitelisted-extension-id in SimpleFeature.

chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/memory/linked_ptr.h"
 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
 #include "extensions/common/error_utils.h"
@@ skipping 46 matching lines @@
         "'background' is only allowed for extensions, hosted apps, and legacy "
             "packaged apps, but this is a packaged app."),
     Testcase("incognito_invalid_platform_app.json",
         "'incognito' is only allowed for extensions and legacy packaged apps, "
             "but this is a packaged app."),
   };
   RunTestcases(
       warning_testcases, arraysize(warning_testcases), EXPECT_TYPE_WARNING);
 }
 
-TEST_F(PlatformAppsManifestTest, PlatformAppContentSecurityPolicy) {
+namespace {
+
+class WhitelistedPlatformAppsManifestTest : public PlatformAppsManifestTest {
+ public:
+  static void SetUpTestCase() {
+    // The whitelisted extension ID is cached, so set it here during test setup.
+    // This is the ID corresponding to the base 64 encoded key in the
+    // init_platform_app_csp.json manifest.
+    std::string test_id = "ahplfneplbnjcflhdgkkjeiglkkfeelb";
+    base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+        switches::kWhitelistedExtensionID, test_id);

[not at google - send to devlin, 2015/03/31 22:21:51]

This is why I wrote ScopedCommandLineSwitch:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

maybe this should be pulled somewhere like extension test utils.

[jackhou1, 2015/03/31 22:55:38]

Unfortunately ScopedCommandLineSwitch doesn't really help in this case because
the cache gets set the first time it's used. But I realised the CommandLine only
needs to be modified at the start of the test (rather than before).

[not at google - send to devlin, 2015/04/01 17:08:21]

It's not so much the cache that I want to reset, rather the commandline. It
seems bad to modify the commandline (process global) in a unit test (supposedly
without side effects). I meant something like:

class WhitelistedPlatformAppsManifestTest : public PlatformAppsManifestTest {
 public:
  static void SetUpTestCase() {
    command_line_.reset(
        new ScopedCommandLineSwitch(switches::kWhitelistedExtensionID,
                                    "ahplfneplbnjcflhdgkkjeiglkkfeelb"));
  }

 private:
  scoped_ptr<ScopedCommandLineSwitch> command_line_;
};

I suppose you'd need to add the key-value version for ScopedCommandLineSwitch in
that case.

Btw should this be in a SetUp method, not SetUpTestCase? I've never seen
SetUpTestCase?

[jackhou1, 2015/04/02 01:28:57]

Looks like this requires a bit of a refactor, maybe something like:
https://codereview.chromium.org/1054813002 ?
Alternatively, I could duplicate ScopedCommandLineSwitch in these tests.
WDYT?
Done. SetUpTestCase gets run before the test subclass is instantiated.

+  }
+};
+
+}  // namespace
+
+TEST_F(WhitelistedPlatformAppsManifestTest, PlatformAppContentSecurityPolicy) {
   // Normal platform apps can't specify a CSP value.
   Testcase warning_testcases[] = {
     Testcase(
         "init_platform_app_csp_warning_1.json",
         "'content_security_policy' is only allowed for extensions and legacy "
             "packaged apps, but this is a packaged app."),
     Testcase(
         "init_platform_app_csp_warning_2.json",
         "'app.content_security_policy' is not allowed for specified extension "
             "ID.")
   };
   RunTestcases(
       warning_testcases, arraysize(warning_testcases), EXPECT_TYPE_WARNING);
 
-  // Whitelisted ones can (this is the ID corresponding to the base 64 encoded
-  // key in the init_platform_app_csp.json manifest.)
-  std::string test_id = "ahplfneplbnjcflhdgkkjeiglkkfeelb";
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kWhitelistedExtensionID, test_id);
+  // Whitelisted ones can.
   scoped_refptr<Extension> extension =
       LoadAndExpectSuccess("init_platform_app_csp.json");
   EXPECT_EQ(0U, extension->install_warnings().size())
       << "Unexpected warning " << extension->install_warnings()[0].message;
   EXPECT_TRUE(extension->is_platform_app());
   EXPECT_EQ("default-src 'self' https://www.google.com;",
             CSPInfo::GetResourceContentSecurityPolicy(extension.get(),
                                                       std::string()));
 
   // But even whitelisted ones must specify a secure policy.
@@ skipping 43 matching lines @@
 
   // Now try again with the experimental flag set.
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kEnableExperimentalExtensionApis);
   for (size_t i = 0; i < arraysize(kPlatformAppExperimentalApis); ++i) {
     LoadAndExpectSuccess(ManifestData(manifests[i].get(), ""));
   }
 }
 
 }  // namespace extensions