Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: sky/engine/bindings/BUILD.gn

Issue 1047883002: gen_snapshot now generates two snapshot buffers, one for the vm isolate (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update dart revision Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/dart/BUILD.gn ('k') | sky/engine/bindings/snapshot.cc.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/BUILD.gn
diff --git a/sky/engine/bindings/BUILD.gn b/sky/engine/bindings/BUILD.gn
index 462c247ba69847ae1083c51c7e5f88bf9fb37fb3..0e8edf2363ecfa6347a482d54aa6f1a519f830db 100644
--- a/sky/engine/bindings/BUILD.gn
+++ b/sky/engine/bindings/BUILD.gn
@@ -61,9 +61,11 @@ action("generate_snapshot_bin") {
"//mojo/public/dart/src/timer_queue.dart",
"snapshot.dart",
]
- output = "$target_gen_dir/snapshot_gen.bin"
+ vm_isolate_snapshot = "$target_gen_dir/vm_isolate_snapshot.bin"
+ isolate_snapshot = "$target_gen_dir/isolate_snapshot.bin"
outputs = [
- output,
+ vm_isolate_snapshot,
+ isolate_snapshot,
]
builtin_path = rebase_path("//sky/engine/bindings/builtin.dart")
@@ -82,8 +84,10 @@ action("generate_snapshot_bin") {
rebase_path("$root_gen_dir"),
"--script",
rebase_path("snapshot.dart"),
+ "--vm_output_bin",
+ rebase_path(vm_isolate_snapshot, root_build_dir),
"--output_bin",
- rebase_path(output, root_build_dir),
+ rebase_path(isolate_snapshot, root_build_dir),
"--target_os",
os,
"--url_mapping=dart:sky,$dart_sky_path",
@@ -99,7 +103,8 @@ action("generate_snapshot_file") {
inputs = [
"//dart/runtime/tools/create_snapshot_file.py",
"snapshot.cc.tmpl",
- "$target_gen_dir/snapshot_gen.bin",
+ "$target_gen_dir/vm_isolate_snapshot.bin",
+ "$target_gen_dir/isolate_snapshot.bin",
]
output = "$target_gen_dir/snapshot.cc"
outputs = [
@@ -108,8 +113,10 @@ action("generate_snapshot_file") {
script = "//dart/runtime/tools/create_snapshot_file.py"
args = [
+ "--vm_input_bin",
+ rebase_path("$target_gen_dir/vm_isolate_snapshot.bin"),
"--input_bin",
- rebase_path("$target_gen_dir/snapshot_gen.bin"),
+ rebase_path("$target_gen_dir/isolate_snapshot.bin"),
"--input_cc",
rebase_path("snapshot.cc.tmpl"),
"--output",
« no previous file with comments | « services/dart/BUILD.gn ('k') | sky/engine/bindings/snapshot.cc.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698