Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: sky/engine/bindings/snapshot.cc.tmpl

Issue 1047883002: gen_snapshot now generates two snapshot buffers, one for the vm isolate (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/bindings/snapshot.cc.tmpl
diff --git a/sky/engine/bindings/snapshot.cc.tmpl b/sky/engine/bindings/snapshot.cc.tmpl
index f0da857d9e016b547c254e0ad4bb9dc50ea0a83a..74ca10e6cc17ceb88b2fe447d8c07b52ba1e7102 100644
--- a/sky/engine/bindings/snapshot.cc.tmpl
+++ b/sky/engine/bindings/snapshot.cc.tmpl
@@ -9,10 +9,17 @@
namespace blink {
// The string on the next line will be filled in with the contents of the
-// generated snapshot binary file.
-// This string forms the content of a snapshot which is loaded in by dart.
-static const uint8_t snapshot_buffer_[] = { % s};
+// generated snapshot binary file for the vm isolate.
+// This string forms the content of the dart vm isolate snapshot which
+// is loaded into the vm isolate.
+static const uint8_t vm_isolate_snapshot_buffer_[] = { % s};
+const uint8_t* kDartVmIsolateSnapshotBuffer = vm_isolate_snapshot_buffer_;
-const uint8_t* kDartSnapshotBuffer = snapshot_buffer_;
+// The string on the next line will be filled in with the contents of the
+// generated snapshot binary file for a regular dart isolate.
+// This string forms the content of a regular dart isolate snapshot which
+// is loaded into an isolate when it is created.
+static const uint8_t isolate_snapshot_buffer_[] = { % s};
+const uint8_t* kDartIsolateSnapshotBuffer = isolate_snapshot_buffer_;
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698