Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: services/dart/BUILD.gn

Issue 1047883002: gen_snapshot now generates two snapshot buffers, one for the vm isolate (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/BUILD.gn
diff --git a/services/dart/BUILD.gn b/services/dart/BUILD.gn
index 1f4041afaeaf3b426706e2dfb2afbfa9364f59fe..d438002083f95c218338cda223de578c8d1a5c9f 100644
--- a/services/dart/BUILD.gn
+++ b/services/dart/BUILD.gn
@@ -23,9 +23,11 @@ action("generate_snapshot_bin") {
"//mojo/public/dart/src/natives.dart",
"//mojo/public/dart/src/timer_queue.dart",
]
- output = "$target_gen_dir/snapshot_gen.bin"
+ vm_isolate_snapshot = "$target_gen_dir/vm_isolate_snapshot.bin"
+ isolate_snapshot = "$target_gen_dir/isolate_snapshot.bin"
outputs = [
- output,
+ vm_isolate_snapshot,
+ isolate_snapshot,
]
gen_snapshot_dir =
@@ -41,8 +43,10 @@ action("generate_snapshot_bin") {
rebase_path("$root_gen_dir"),
"--script",
rebase_path("snapshot.dart"),
+ "--vm_output_bin",
+ rebase_path(vm_isolate_snapshot, root_build_dir),
"--output_bin",
- rebase_path(output, root_build_dir),
+ rebase_path(isolate_snapshot, root_build_dir),
"--target_os",
os,
"--url_mapping=dart:mojo.builtin,$builtin_path",
@@ -57,7 +61,8 @@ action("generate_snapshot_file") {
inputs = [
"//dart/runtime/tools/create_snapshot_file.py",
"//mojo/dart/embedder/snapshot.cc.tmpl",
- "$target_gen_dir/snapshot_gen.bin",
+ "$target_gen_dir/vm_isolate_snapshot.bin",
+ "$target_gen_dir/isolate_snapshot.bin",
]
output = "$target_gen_dir/snapshot.cc"
outputs = [
@@ -66,8 +71,10 @@ action("generate_snapshot_file") {
script = "//dart/runtime/tools/create_snapshot_file.py"
args = [
+ "--vm_input_bin",
+ rebase_path("$target_gen_dir/vm_isolate_snapshot.bin"),
"--input_bin",
- rebase_path("$target_gen_dir/snapshot_gen.bin"),
+ rebase_path("$target_gen_dir/isolate_snapshot.bin"),
"--input_cc",
rebase_path("//mojo/dart/embedder/snapshot.cc.tmpl"),
"--output",

Powered by Google App Engine
This is Rietveld 408576698