Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1047883002: gen_snapshot now generates two snapshot buffers, one for the vm isolate (Closed)

Created:
5 years, 8 months ago by siva
Modified:
5 years, 8 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

gen_snapshot now generates two snapshot buffers, one for the vm isolate and another for a regular isolate. These changes account for that change in the mojo and sky snapshot generation scripts and the controller files. R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6367b59715953eeb637484514c094ce77ad2da0b

Patch Set 1 #

Patch Set 2 : update comments #

Total comments: 4

Patch Set 3 : address review comments #

Patch Set 4 : update dart revision #

Patch Set 5 : update dart revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -41 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 1 2 7 chunks +11 lines, -9 lines 0 comments Download
M mojo/dart/embedder/snapshot.cc.tmpl View 1 1 chunk +12 lines, -4 lines 0 comments Download
M mojo/dart/embedder/test/BUILD.gn View 4 chunks +12 lines, -5 lines 0 comments Download
M services/dart/BUILD.gn View 4 chunks +12 lines, -5 lines 0 comments Download
M sky/engine/bindings/BUILD.gn View 4 chunks +12 lines, -5 lines 0 comments Download
M sky/engine/bindings/snapshot.cc.tmpl View 1 1 chunk +11 lines, -4 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 2 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
siva
5 years, 8 months ago (2015-03-31 14:30:58 UTC) #2
zra
lgtm https://codereview.chromium.org/1047883002/diff/20001/mojo/dart/embedder/dart_controller.cc File mojo/dart/embedder/dart_controller.cc (right): https://codereview.chromium.org/1047883002/diff/20001/mojo/dart/embedder/dart_controller.cc#newcode459 mojo/dart/embedder/dart_controller.cc:459: result = Dart_Initialize(nullptr, // vm isolate snapshot buffer. ...
5 years, 8 months ago (2015-03-31 14:37:33 UTC) #3
siva
Addressed review comments and changed DEPS file for picking up newer revision of dart. https://codereview.chromium.org/1047883002/diff/20001/mojo/dart/embedder/dart_controller.cc ...
5 years, 8 months ago (2015-03-31 19:52:20 UTC) #4
siva
Updated the dart revision to 44854 and the try bots are green now.
5 years, 8 months ago (2015-04-02 01:37:16 UTC) #5
siva
5 years, 8 months ago (2015-04-02 18:31:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
6367b59715953eeb637484514c094ce77ad2da0b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698