fix for dartbug.com/23032 - breakpoints not triggering

editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/dartium/BreakpointManager.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
@@ skipping 20 matching lines @@
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IMarkerDelta;
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IWorkspaceRoot;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.debug.core.DebugPlugin;
 import org.eclipse.debug.core.IBreakpointListener;
 import org.eclipse.debug.core.model.IBreakpoint;
 
 import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
 /**
  * Handle adding a removing breakpoints to the WebKit connection for the DartiumDebugTarget class.
  */
 public class BreakpointManager implements IBreakpointListener, DartBreakpointManager {
   public static class NullBreakpointManager implements DartBreakpointManager {
@@ skipping 178 matching lines @@
       filePath = fileLocation;
       packagePath = resolvePathToPackage(resource, filePath);
       if (packagePath != null && packagePath.startsWith(DartCore.PACKAGE_SCHEME_SPEC)) {
         packagePath = packagePath.substring(DartCore.PACKAGE_SCHEME_SPEC.length());
       }
       if (packagePath != null && packagePath.startsWith(FILE_SPEC)) {
         packagePath = packagePath.substring(FILE_SPEC.length());
         if (DartCore.isWindows() && packagePath.startsWith("/")) {
           packagePath = packagePath.substring(1);
         }
+        try {
+          // server returns a url encoded string, so decode before matching
+          packagePath = URLDecoder.decode(packagePath, "UTF-8");
+        } catch (UnsupportedEncodingException e) {
+          DartCore.logError(e);
+        }
         if (new Path(packagePath).equals(new Path(fileLocation))) {
           return null;
         }
       }
     } else {
 
       Path path = new Path(regex);
       int i = 0;
       if (regex.indexOf(LIB_DIRECTORY_PATH) != -1) {
         // remove all segments after "lib", they show path in the package
@@ skipping 216 matching lines @@
       }
     }
 
     if (container.getParent() instanceof IWorkspaceRoot) {
       return false;
     }
 
     return isPubLib(container.getParent());
   }
 }