ui: Clean up UITestSuite initialization.

ui: Remove unnecessary pak file loading in UITestSuite.

We already load chrome.pak and en-US.pak which includes all the necessary
strings and images for the tests.

This also fixes the following errors I'm seeing in ui_unittests target.

[18617:18617:0104/164229:7580537011:ERROR:memory_mapped_file.cc(23)] Couldn't open /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
[18617:18617:0104/164229:7580537130:ERROR:data_pack.cc(78)] Failed to mmap datapack
[18617:18617:0104/164229:7580537189:ERROR:resource_bundle.cc(607)] Failed to load /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
Some features may not be available.

BUG=144345
TEST=ui_unittests, app_list_unittests, message_center_unittests
R=tony@chromium.org
TBR=ben

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243557

[tfarina, 2014-01-04 18:50:45]

Let's see if the bots agree with me.

Tony, please review.

Robert, Chris, I'm adding you because git blame says you guys touched these
lines I'm removing.

Thanks!

[tony, 2014-01-06 17:51:13]

LGTM. Please update the description to say what and why you're doing it.  E.g.,
instead of saying "Clean up UITestSuite initialization", say something like:
"Remove unnecessary pak file loading.

We already load chrome.pak and en-US.pak which includes all the necessary
strings."

Does this mean that the dependencies for the ui_unittests target are incorrect? 
Should ui_unittests depend on chrome_resources.gyp:packed_resources?

[tfarina, 2014-01-08 01:49:06]

On 2014/01/06 17:51:13, tony wrote:
> LGTM. Please update the description to say what and why you're doing it. 
E.g.,
> instead of saying "Clean up UITestSuite initialization", say something like:
> "Remove unnecessary pak file loading.
> 
> We already load chrome.pak and en-US.pak which includes all the necessary
> strings."
> 
Much better! I was not sure how to describe my change as you noticed :(

> Does this mean that the dependencies for the ui_unittests target are
incorrect? 
> Should ui_unittests depend on chrome_resources.gyp:packed_resources?
I think it makes more sense to depend on packed_resources for now as we are
loading chrome_100_percent.pak. I have changed it to depend on packed_resources
instead of ui_resources and ui_strings. Once things are cleared, we will
probably change that to ui_test_pak.

[tfarina, 2014-01-08 01:49:34]

TBRing Ben for that...

[commit-bot: I haz the power, 2014-01-08 01:51:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/104783007/100001

[commit-bot: I haz the power, 2014-01-08 02:08:41]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-08 04:07:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/104783007/360001

[commit-bot: I haz the power, 2014-01-08 04:29:57]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-08 04:47:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/104783007/550001

[commit-bot: I haz the power, 2014-01-08 04:56:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/104783007/600001

[commit-bot: I haz the power, 2014-01-08 11:21:20]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 12:55:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/104783007/600001

[commit-bot: I haz the power, 2014-01-08 14:40:27]

Change committed as 243557