Fix for an issue while breaking out of an empty list item in case of nested lists

Fix for an issue while breaking out of an empty list item in case of nested lists

In case of nested lists, if we break out of the inner list in such a way that
it is split into two inner lists, then break out of the first inner list
(which lands us in outer list) and then try to break out of the outer list,
it fails. Currently, in such scenario we cannot break out of the outer list.

This is caused by appendedSublist() called from enclosingEmptyListItem().
In appendedSublist() we check if the next sibling of the list item(of outer list)
from which we are trying to break out is a list(second inner list), in this case
we will not consider this list item as an empty one. Thus, we cannot break out.

Extending the check in appendedSublist() so as to additionally check if the
list which is the next sibling of list item from which we are trying to break out
is not a descendant of the outer list(to which list item belongs), fixes the issue.
i.e. Change the following check in appendedSubList()
if (isListElement(n))
    return toHTMLElement(n);
            to
if (isListElement(n) && !n->isDescendantOf(enclosingList(listItem)))
    return toHTMLElement(n);

But further analysis seemed to show that the check
if (embeddedSublist(listChildNode) || appendedSublist(listChildNode))
        return 0;

which we do in enclosingEmptyListItem() is not needed. Because in the cases
where the list item from which we are trying to break out has an embeddedSublist
or appendedSublist we would still want to break out of the list. Getting rid of
this check and hence these functions(which are not used anywhere else),
fixes the issue.


BUG=328037
TEST=LayoutTests/editing/inserting/break-out-of-nested-lists.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164049

[vanihegde, 2013-12-12 13:47:57]

I could not think of any scenario where in we would need the check,
if (embeddedSublist(listChildNode) || appendedSublist(listChildNode))
        return 0;
to avoid breaking out of the list.

I tried all layout tests with this change and have also manually tried several
scenarios I could think of.

Please take a look and let me know if I have missed any scenario wherein we
would need these checks.

[yosin_UTC9, 2013-12-13 01:12:07]

Could you upload this patch again? Base file for htmlediting.cpp is missing.

[vanihegde, 2013-12-13 02:59:34]

On 2013/12/13 01:12:07, Yoshi wrote:
> Could you upload this patch again? Base file for htmlediting.cpp is missing.

Oh, I did not notice that. I have uploaded the patch again.

[ojan, 2013-12-18 01:10:37]

lgtm

[commit-bot: I haz the power, 2013-12-18 01:10:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/104783005/20001

[commit-bot: I haz the power, 2013-12-18 04:07:17]

Change committed as 164049