Allow the "img.src='';img.src='.." idiom to clear down images immediately.

Allow the "img.src='';img.src='.." idiom to clear down images immediately.

When we updated image loading to handle alt content using the shadow dom we made
most image loads asynchronous, including loads where the src is null.

In both of these bugs authors were depending on img.src='' to clear down the image
synchronously. Since the idiom is widely used we need to un-break it!

BUG=468915, 469678
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193301

[rhogan, 2015-03-31 18:27:57]

robhogan@gmail.com changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-04-06 20:29:41]

https://codereview.chromium.org/1047803005/diff/1/LayoutTests/fast/images/nat...
File LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html
(right):

https://codereview.chromium.org/1047803005/diff/1/LayoutTests/fast/images/nat...
LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html:21:
setTimeout("img.src = '" + testImage + "';", 0);
don't use eval, use a closure.

https://codereview.chromium.org/1047803005/diff/1/LayoutTests/fast/images/nat...
LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html:26:
<div id="result">FAIL</div>
Would it be possible to use js-test.js instead?

https://codereview.chromium.org/1047803005/diff/1/LayoutTests/fast/images/onl...
File
LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html
(right):

https://codereview.chromium.org/1047803005/diff/1/LayoutTests/fast/images/onl...
LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-null-src-load.html:21:
setTimeout("img.src='" + resetImage + "';img.src = '" + testImage + "';", 0);
function() { }

don't use eval.

[pdr., 2015-04-06 21:23:42]

LGTM, I think the approach you've taken is pragmatic.

[rhogan, 2015-04-07 18:26:14]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-04-07 18:26:14]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1047803005/#ps20001
(title: "Updated")

[commit-bot: I haz the power, 2015-04-07 18:26:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047803005/20001

[commit-bot: I haz the power, 2015-04-07 20:55:28]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193301