skia: Fix text subpixel half sample default for GPU rasterization

skia: Fix text subpixel half sample default for GPU rasterization

In software, SkDraw1Glyph::Proc SkDraw1Glyph::init initializes
fHalfSampleX, fHalfSampleY to SkGlyph::kSubpixelRound.  In hardware,
however, these values were initialized to zero.

Fix, match software's implementation

BUG=471919
Committed: https://skia.googlesource.com/skia/+/e0f812a7a107986dfa72e6855c1608b077428136

[hendrikw, 2015-03-31 00:19:06]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-03-31 00:19:07]

PTAL, thanks!

[bsalomon, 2015-03-31 15:02:34]

bsalomon@google.com changed reviewers:
+ jvanverth@google.com

[bsalomon, 2015-03-31 15:02:35]

looks like a change to me. :) I don't really know much about the text code.
Throwing it over the wall to Jim.

[jvanverth1, 2015-03-31 17:48:57]

LGTM.

One thought -- it might be cleaner to move the definition of halfSampleX and
halfSampleY into the "if (cache->isSubpixel())" block, and then remove the
mysterious comments in the 'else' block. That would obscure the similarity to
SkDraw, but that connection is getting pretty tenuous as it is.

[hendrikw, 2015-03-31 18:08:43]

Yeah, good idea, done!

[hendrikw, 2015-03-31 18:34:06]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-03-31 18:34:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1047803004/#ps20001
(title: "move declaration of halfSampleX, Y")

[commit-bot: I haz the power, 2015-03-31 18:34:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047803004/20001

[commit-bot: I haz the power, 2015-03-31 19:02:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e0f812a7a107986dfa72e6855c1608b077428136