Web MIDI API: disallow to add custom exceptions on content settings UI

Web MIDI API: disallow to add custom exceptions on content settings UI

To disallow to add exceptions for non-secure origin, make midi-sysex
permission impossible to edit on content settings UI for now.

BUG=470170
Committed: https://crrev.com/ccabd7eb46c3a472c4be96cac6209c966ac354f8
Cr-Commit-Position: refs/heads/master@{#323173}

[Takashi Toyoshima, 2015-03-30 18:47:40]

toyoshim@chromium.org changed reviewers:
+ dbeam@chromium.org

[Takashi Toyoshima, 2015-03-30 18:48:45]

please take a look.

[Dan Beam, 2015-03-30 22:10:27]

lgtm w/nit

https://codereview.chromium.org/1047793002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/content_settings_exceptions_area.js
(right):

https://codereview.chromium.org/1047793002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/content_settings_exceptions_area.js:160:
this.contentType == 'midi-sysex') {
any idea why zoomlevels isn't in this list?  if it was, we could just say:

  this.editable = this.isEditable();

or something

[Takashi Toyoshima, 2015-03-31 03:15:30]

For zoomlevels, it was set at a different place;
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

fullscreen is another exception. But definitely it should not be editable.
Otherwise, user can add an arbitrary item by editing existing item. That does
not make sense.

So, changing it to "editable = this.isEditable()" looks fine.

[Takashi Toyoshima, 2015-03-31 03:21:58]

Since the editable is modified, "this.editable = this.editable &&
this.isEditable()" looks fine.

[Takashi Toyoshima, 2015-03-31 03:24:46]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2015-03-31 03:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1047793002/#ps20001
(title: "reuse isEditable()")

[commit-bot: I haz the power, 2015-03-31 03:24:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047793002/20001

[commit-bot: I haz the power, 2015-03-31 04:33:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 04:33:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Takashi Toyoshima, 2015-03-31 05:21:14]

oops, class(prototype) was different :(

[Takashi Toyoshima, 2015-03-31 06:42:07]

patch set 3 factors out isEditable() to a common function.
please take another look since the change is not mechanical thing.

[Takashi Toyoshima, 2015-04-01 01:54:06]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2015-04-01 01:54:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1047793002/#ps60001
(title: "relocation")

[commit-bot: I haz the power, 2015-04-01 01:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047793002/60001

[commit-bot: I haz the power, 2015-04-01 02:58:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-01 02:59:49]

Patchset 4 (id:??) landed as
https://crrev.com/ccabd7eb46c3a472c4be96cac6209c966ac354f8
Cr-Commit-Position: refs/heads/master@{#323173}