Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1047783002: compositor-worker: Allow registering compositor-frame callbacks. (Closed)

Created:
5 years, 8 months ago by sadrul
Modified:
5 years, 8 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

compositor-worker: Allow registering compositor-frame callbacks. Use the refactored FrameRequestCallbackCollection for managing the list of compositor-frame callbacks. BUG=436952 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192936

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M Source/modules/compositorworker/CompositorWorkerGlobalScope.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerGlobalScope.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
esprehn
This is confusing since requsetCompositorFrame maps to something called requestAnimationFrame internally. https://codereview.chromium.org/1047783002/diff/1/Source/modules/compositorworker/CompositorWorkerGlobalScope.h File Source/modules/compositorworker/CompositorWorkerGlobalScope.h (right): ...
5 years, 8 months ago (2015-03-30 18:43:12 UTC) #2
sadrul
https://codereview.chromium.org/1047783002/diff/1/Source/modules/compositorworker/CompositorWorkerGlobalScope.h File Source/modules/compositorworker/CompositorWorkerGlobalScope.h (right): https://codereview.chromium.org/1047783002/diff/1/Source/modules/compositorworker/CompositorWorkerGlobalScope.h#newcode29 Source/modules/compositorworker/CompositorWorkerGlobalScope.h:29: int requestCompositorFrame(RequestAnimationFrameCallback*); On 2015/03/30 18:43:12, esprehn wrote: > Why ...
5 years, 8 months ago (2015-03-31 02:45:36 UTC) #3
sadrul
+tkent@ for owner review in Source/modules/ [Note: This CL depends on https://codereview.chromium.org/1043903003/ which is under ...
5 years, 8 months ago (2015-03-31 22:14:29 UTC) #5
tkent
lgtm
5 years, 8 months ago (2015-03-31 23:25:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047783002/40001
5 years, 8 months ago (2015-04-01 12:05:14 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 13:23:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192936

Powered by Google App Engine
This is Rietveld 408576698