Make the Mouse integration work in Virtualbox

Make the Mouse integration work in Virtualbox

XI2.2 and above include enough information in response to
XIQueryDevice to decide whether a particular device supports
touch input or not. So we remove the legacy code that is no
longer necessary.

This fixes mouse-input in virtualbox.

BUG=456222
Committed: https://crrev.com/ad780aadaade136c6ac1711d9d0a8ebccde3d8a1
Cr-Commit-Position: refs/heads/master@{#322895}

[lanwei, 2015-03-30 20:58:13]

lanwei@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2015-03-30 21:19:00]

You can change the CL description to something like:

"""XI2.2 and above includes enough information in response to
XIQueryDevice to decide whether a particular device supports
touch input or not. So remove the legacy code that is no
longer necessary.

This fixes mouse-input in virtualbox.

BUG=...."""

As a follow up (and separate from this patch), can you look at the rest of the
uses of GetXDeviceList() and see if we can remove those too?

https://codereview.chromium.org/1047733003/diff/1/ui/events/devices/x11/touch...
File ui/events/devices/x11/touch_factory_x11.cc (right):

https://codereview.chromium.org/1047733003/diff/1/ui/events/devices/x11/touch...
ui/events/devices/x11/touch_factory_x11.cc:88: // With XI2.1 or older, we allow
only single touch devices.
Not sure what you mean by 'this will return null'. Do you mean this function, or
the call to GetXIDeviceList(), or the call to GetXDeviceList()?

I think you can just remove this entire comment.

[lanwei, 2015-03-30 21:36:01]

On 2015/03/30 21:19:00, sadrul wrote:
> You can change the CL description to something like:
> 
> """XI2.2 and above includes enough information in response to
> XIQueryDevice to decide whether a particular device supports
> touch input or not. So remove the legacy code that is no
> longer necessary.
> 
> This fixes mouse-input in virtualbox.
> 
> BUG=...."""
> 
> As a follow up (and separate from this patch), can you look at the rest of the
> uses of GetXDeviceList() and see if we can remove those too?
> 
>
https://codereview.chromium.org/1047733003/diff/1/ui/events/devices/x11/touch...
> File ui/events/devices/x11/touch_factory_x11.cc (right):
> 
>
https://codereview.chromium.org/1047733003/diff/1/ui/events/devices/x11/touch...
> ui/events/devices/x11/touch_factory_x11.cc:88: // With XI2.1 or older, we
allow
> only single touch devices.
> Not sure what you mean by 'this will return null'. Do you mean this function,
or
> the call to GetXIDeviceList(), or the call to GetXDeviceList()?
> 
> I think you can just remove this entire comment.

I will create a new issue to see if we can completely clean up all the
GetXDeviceList function.

[lanwei, 2015-03-30 21:36:28]

https://codereview.chromium.org/1047733003/diff/1/ui/events/devices/x11/touch...
File ui/events/devices/x11/touch_factory_x11.cc (right):

https://codereview.chromium.org/1047733003/diff/1/ui/events/devices/x11/touch...
ui/events/devices/x11/touch_factory_x11.cc:88: // With XI2.1 or older, we allow
only single touch devices.
On 2015/03/30 21:19:00, sadrul wrote:
> Not sure what you mean by 'this will return null'. Do you mean this function,
or
> the call to GetXIDeviceList(), or the call to GetXDeviceList()?
> 
> I think you can just remove this entire comment.

I mean the two lists, touch_device_lookup_, touch_device_list_, because they are
not setup. Never mind, the comments seem unnecessary, I removed it.

Done.

[sadrul, 2015-03-30 21:37:10]

Very cool! LGTM

[lanwei, 2015-03-30 22:44:29]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2015-03-30 22:45:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047733003/20001

[commit-bot: I haz the power, 2015-03-30 22:55:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-30 22:56:51]

Patchset 2 (id:??) landed as
https://crrev.com/ad780aadaade136c6ac1711d9d0a8ebccde3d8a1
Cr-Commit-Position: refs/heads/master@{#322895}