Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1047703003: Add ability to capture SKPs from Chromium's pagesets (Closed)

Created:
5 years, 8 months ago by rmistry
Modified:
5 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ability to capture SKPs from Chromium's pagesets Also added support for pagesets with multiple pages in them. #crskps BUG=skia:1723 BUG=skia:3574 NOTRY=true Committed: https://skia.googlesource.com/skia/+/49d093cef9d571877a07173e879a765ef83a90b9

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : More cleanup #

Patch Set 4 : More cleanup #

Total comments: 4

Patch Set 5 : Addressing codereview comments #

Patch Set 6 : Cleanup #

Patch Set 7 : Rebase #

Patch Set 8 : Comment out cr pagesets for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -16 lines) Patch
M tools/skp/webpages_playback.py View 1 2 3 4 5 6 7 7 chunks +55 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmistry
5 years, 8 months ago (2015-03-30 17:30:18 UTC) #2
borenet
https://codereview.chromium.org/1047703003/diff/60001/tools/skp/webpages_playback.py File tools/skp/webpages_playback.py (right): https://codereview.chromium.org/1047703003/diff/60001/tools/skp/webpages_playback.py#newcode111 tools/skp/webpages_playback.py:111: CHROMIUM_PAGE_SETS_PATH = 'tools/perf/page_sets' os.path.join? https://codereview.chromium.org/1047703003/diff/60001/tools/skp/webpages_playback.py#newcode368 tools/skp/webpages_playback.py:368: _, ps_filename = ...
5 years, 8 months ago (2015-03-30 19:31:57 UTC) #3
rmistry
https://codereview.chromium.org/1047703003/diff/60001/tools/skp/webpages_playback.py File tools/skp/webpages_playback.py (right): https://codereview.chromium.org/1047703003/diff/60001/tools/skp/webpages_playback.py#newcode111 tools/skp/webpages_playback.py:111: CHROMIUM_PAGE_SETS_PATH = 'tools/perf/page_sets' On 2015/03/30 19:31:57, borenet wrote: > ...
5 years, 8 months ago (2015-03-30 20:11:18 UTC) #4
borenet
LGTM
5 years, 8 months ago (2015-03-31 11:15:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047703003/140001
5 years, 8 months ago (2015-03-31 12:04:22 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 12:04:34 UTC) #9
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/49d093cef9d571877a07173e879a765ef83a90b9

Powered by Google App Engine
This is Rietveld 408576698