[Android] Clean up old_interface in build/android/.

build/android/pylib/gtest/test_package_exe.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Defines TestPackageExecutable to help run stand-alone executables."""
 
 import logging
 import os
+import posixpath
 import sys
 import tempfile
 
 from pylib import cmd_helper
 from pylib import constants
 from pylib import pexpect
 from pylib.device import device_errors
 from pylib.gtest import gtest_test_instance
 from pylib.gtest.test_package import TestPackage
 
@@ skipping 93 matching lines @@
     cmd_helper.RunCmd(['chmod', '+x', sh_script_file.name])
     device.PushChangedFiles([(
         sh_script_file.name,
         constants.TEST_EXECUTABLE_DIR + '/chrome_test_runner.sh')])
     logging.info('Conents of the test runner script: ')
     for line in open(sh_script_file.name).readlines():
       logging.info('  ' + line.rstrip())
 
   #override
   def GetAllTests(self, device):
-    cmd = '%s %s/%s --gtest_list_tests' % (self.tool.GetTestWrapper(),
-        constants.TEST_EXECUTABLE_DIR, self.suite_name)
     lib_path = '%s/%s_deps' % (constants.TEST_EXECUTABLE_DIR, self.suite_name)

[perezju, 2015/03/30 16:01:17]

nit: maybe should also use posixpath.join?

[jbudorick, 2015/03/30 16:42:14]

Done.

-    (exit_code, output) = device.old_interface.GetAndroidToolStatusAndOutput(
-        cmd, lib_path=lib_path)
-    if exit_code != 0:
-      raise Exception(
-          'Failed to start binary:\n%s' % '\n'.join(output))
+    output = device.RunShellCommand(
+        [device.GetDevicePieWrapper(), self.tool.GetTestWrapper(),

[perezju, 2015/03/30 16:01:16]

only pass wrappers if needed.

[jbudorick, 2015/03/30 16:42:14]

Done.

+         posixpath.join(constants.TEST_EXECUTABLE_DIR, self.suite_name),
+         '--gtest_list_tests'],
+        check_return=True,
+        env={'LD_LIBRARY_PATH': lib_path})
     return gtest_test_instance.ParseGTestListTests(output)
 
   #override
   def SpawnTestProcess(self, device):
     args = ['adb', '-s', str(device), 'shell', 'sh',
             constants.TEST_EXECUTABLE_DIR + '/chrome_test_runner.sh']
     logging.info(args)
     return pexpect.spawn(args[0], args[1:], logfile=sys.stdout)
 
   #override
@@ skipping 13 matching lines @@
             'stripped binary (%s, timestamp %d) older than '
             'source binary (%s, timestamp %d), build target %s' %
             (target_name, target_mtime, self.suite_path, source_mtime,
              self.suite_name + '_stripped'))
 
     test_binary_path = constants.TEST_EXECUTABLE_DIR + '/' + self.suite_name
     device.PushChangedFiles([(target_name, test_binary_path)])
     deps_path = self.suite_path + '_deps'
     if os.path.isdir(deps_path):
       device.PushChangedFiles([(deps_path, test_binary_path + '_deps')])