Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1047663002: Remove unused method (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
Jay Civelli, huangs
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@canvas
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused method TestingProfile::CreateFallbackIconService() is never called. As no tests depends on a FallbackIconService, remove this method. BUG=455063 Committed: https://crrev.com/3e00086048d6a8c9db40e9bf1bdac17acc046dac Cr-Commit-Position: refs/heads/master@{#323000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/test/base/testing_profile.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
jcivelli: please take a look This method was introduced in https://codereview.chromium.org/996253002/ but is not currently ...
5 years, 8 months ago (2015-03-30 09:55:12 UTC) #3
sdefresne
huangs: FYI as original author of https://codereview.chromium.org/996253002/
5 years, 8 months ago (2015-03-30 09:55:40 UTC) #4
Jay Civelli
lgtm
5 years, 8 months ago (2015-03-30 17:05:47 UTC) #5
huangs
Acknowledged, LGTM.
5 years, 8 months ago (2015-03-30 17:23:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047663002/1
5 years, 8 months ago (2015-03-31 07:50:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 09:09:35 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 09:10:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e00086048d6a8c9db40e9bf1bdac17acc046dac
Cr-Commit-Position: refs/heads/master@{#323000}

Powered by Google App Engine
This is Rietveld 408576698