Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1903)

Unified Diff: content/renderer/devtools/devtools_agent.h

Issue 1047653003: [DevTools] Unpause renderer when paused RenderFrame is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/devtools/devtools_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_agent.h
diff --git a/content/renderer/devtools/devtools_agent.h b/content/renderer/devtools/devtools_agent.h
index 9db85c425c61487e2dfb97cd6f1a01bf8412aae7..1979f3882a194d3bab498b1cbd8f1fac4496df97 100644
--- a/content/renderer/devtools/devtools_agent.h
+++ b/content/renderer/devtools/devtools_agent.h
@@ -7,6 +7,7 @@
#include <string>
+#include "content/common/content_export.h"
#include "content/public/common/console_message_level.h"
#include "content/public/renderer/render_frame_observer.h"
#include "third_party/WebKit/public/web/WebDevToolsAgentClient.h"
@@ -22,8 +23,9 @@ class RenderFrameImpl;
// DevToolsAgent belongs to the inspectable RenderFrameImpl and communicates
// with WebDevToolsAgent. There is a corresponding DevToolsAgentHost
// on the browser side.
-class DevToolsAgent : public RenderFrameObserver,
- public blink::WebDevToolsAgentClient {
+class CONTENT_EXPORT DevToolsAgent
+ : public RenderFrameObserver,
+ NON_EXPORTED_BASE(public blink::WebDevToolsAgentClient) {
public:
explicit DevToolsAgent(RenderFrameImpl* frame);
~DevToolsAgent() override;
@@ -43,8 +45,11 @@ class DevToolsAgent : public RenderFrameObserver,
bool IsAttached();
private:
+ friend class DevToolsAgentTest;
+
// RenderFrameObserver implementation.
bool OnMessageReceived(const IPC::Message& message) override;
+ void WidgetWillClose() override;
// WebDevToolsAgentClient implementation.
void sendProtocolMessage(int call_id,
@@ -72,6 +77,7 @@ class DevToolsAgent : public RenderFrameObserver,
bool is_attached_;
bool is_devtools_client_;
bool paused_in_mouse_move_;
+ bool paused_;
RenderFrameImpl* frame_;
DISALLOW_COPY_AND_ASSIGN(DevToolsAgent);
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/devtools/devtools_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698