Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1047463003: Add cloud_print_unittests to the GN build. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remoting_targets
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cloud_print_unittests to the GN build. BUG=461019 R=brettw@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/9dfded663c2b6682c59ce5554c4d07564100ea5a Cr-Commit-Position: refs/heads/master@{#323262}

Patch Set 1 : remove comments #

Patch Set 2 : merge to #322929 #

Total comments: 2

Patch Set 3 : remove //cloud_print group target #

Patch Set 4 : merge to #323155 #

Patch Set 5 : make cloud_print_unittests linux-only for now #

Patch Set 6 : fix gn check failure #

Patch Set 7 : fix dependency on content #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1 line) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
A cloud_print/BUILD.gn View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A cloud_print/service/BUILD.gn View 1 2 3 4 5 6 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Dirk Pranke
5 years, 8 months ago (2015-03-30 21:32:08 UTC) #3
brettw
lgtm https://codereview.chromium.org/1047463003/diff/40001/cloud_print/BUILD.gn File cloud_print/BUILD.gn (right): https://codereview.chromium.org/1047463003/diff/40001/cloud_print/BUILD.gn#newcode7 cloud_print/BUILD.gn:7: group("cloud_print") { It looks like this is never ...
5 years, 8 months ago (2015-03-31 18:02:06 UTC) #4
Dirk Pranke
https://codereview.chromium.org/1047463003/diff/40001/cloud_print/BUILD.gn File cloud_print/BUILD.gn (right): https://codereview.chromium.org/1047463003/diff/40001/cloud_print/BUILD.gn#newcode7 cloud_print/BUILD.gn:7: group("cloud_print") { On 2015/03/31 18:02:05, brettw wrote: > It ...
5 years, 8 months ago (2015-03-31 18:12:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047463003/80001
5 years, 8 months ago (2015-04-01 00:55:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/271) win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, ...
5 years, 8 months ago (2015-04-01 01:06:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047463003/80002
5 years, 8 months ago (2015-04-01 01:45:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/74308)
5 years, 8 months ago (2015-04-01 02:32:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047463003/110001
5 years, 8 months ago (2015-04-01 02:47:09 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/74320)
5 years, 8 months ago (2015-04-01 03:31:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047463003/130001
5 years, 8 months ago (2015-04-01 15:15:23 UTC) #23
commit-bot: I haz the power
Committed patchset #7 (id:130001)
5 years, 8 months ago (2015-04-01 17:00:42 UTC) #24
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 17:01:24 UTC) #25
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9dfded663c2b6682c59ce5554c4d07564100ea5a
Cr-Commit-Position: refs/heads/master@{#323262}

Powered by Google App Engine
This is Rietveld 408576698