Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1047413003: Revert of Implement DisplayList GatherPixelRefs (Closed)

Created:
5 years, 8 months ago by weiliangc
Modified:
5 years, 8 months ago
Reviewers:
ajuma, vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chrishtr, chromium-reviews, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement DisplayList GatherPixelRefs (patchset #5 id:80001 of https://codereview.chromium.org/1045953002/) Reason for revert: Cause of crbug.com/472590 Original issue's description: > Implement DisplayList GatherPixelRefs > > Take advantage of DisplayList playing back to generate SkPicture, and > use existing functions that gathers pixel ref from a single SkPicture. > > R=ajuma, enne, vmpstr > BUG=440468 > > Committed: https://crrev.com/3d69b19b57904847ffec31b0f5d4f3568b5c6f35 > Cr-Commit-Position: refs/heads/master@{#323152} TBR=enne@chromium.org,ajuma@chromium.org,vmpstr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440468 Committed: https://crrev.com/74cb97d8d5c4e62a694c7f029a7c8c0b09e5bd92 Cr-Commit-Position: refs/heads/master@{#323321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -856 lines) Patch
M cc/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/cc_tests.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M cc/resources/display_item_list.h View 3 chunks +0 lines, -6 lines 0 comments Download
M cc/resources/display_item_list.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M cc/resources/display_list_raster_source.cc View 1 chunk +1 line, -10 lines 0 comments Download
M cc/resources/display_list_recording_source.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/resources/display_list_recording_source.cc View 3 chunks +1 line, -5 lines 0 comments Download
D cc/resources/display_list_recording_source_unittest.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M cc/resources/picture_pile_impl_unittest.cc View 11 chunks +379 lines, -9 lines 0 comments Download
M cc/resources/pixel_ref_map.h View 3 chunks +1 line, -5 lines 0 comments Download
M cc/resources/pixel_ref_map.cc View 3 chunks +37 lines, -52 lines 0 comments Download
D cc/resources/recording_source_unittest.cc View 1 chunk +0 lines, -445 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 2 chunks +4 lines, -18 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 2 chunks +0 lines, -22 lines 0 comments Download
D cc/test/fake_display_list_recording_source.h View 1 chunk +0 lines, -88 lines 0 comments Download
M cc/test/fake_picture_pile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_pile.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
weiliangc
Created Revert of Implement DisplayList GatherPixelRefs
5 years, 8 months ago (2015-04-01 20:35:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047413003/1
5 years, 8 months ago (2015-04-01 20:36:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 20:37:49 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/74cb97d8d5c4e62a694c7f029a7c8c0b09e5bd92 Cr-Commit-Position: refs/heads/master@{#323321}
5 years, 8 months ago (2015-04-01 20:38:44 UTC) #5
weiliangc
5 years, 8 months ago (2015-04-01 20:48:48 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1050103003/ by weiliangc@chromium.org.

The reason for reverting is: Break tree.

Powered by Google App Engine
This is Rietveld 408576698