shell/application_manager/native_runner.h - Issue 1047333002: For the out-of-process NativeRunner, make sure that Start()'s callback always gets called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/application_manager/native_runner.h

Issue 1047333002: For the out-of-process NativeRunner, make sure that Start()'s callback always gets called. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: shell/application_manager/native_runner.h

diff --git a/shell/application_manager/native_runner.h b/shell/application_manager/native_runner.h

index abcff9009a48219a4ac4ead9c18c822dc648be50..5317cbb2c924f030f0a4b6d0057d91c221bf0cb5 100644

--- a/shell/application_manager/native_runner.h

+++ b/shell/application_manager/native_runner.h

@@ -27,7 +27,8 @@ class NativeRunner {

// Loads the app in the file at |app_path| and runs it on some other

// thread/process. If |cleanup| is |DELETE|, this takes ownership of the file.

// |app_completed_callback| is posted (to the thread on which |Start()| was

- // called) after |MojoMain()| completes.

+ // called) after |MojoMain()| completes, or on any error (including if it

+ // fails to start).

// TODO(vtl): |app_path| and |cleanup| should probably be moved to the

// factory's Create(). Rationale: The factory may need information from the

// file to decide what kind of NativeRunner to make.

« no previous file with comments | « shell/app_child_process_host_unittest.cc ('k') | shell/child_process_host.h » ('j') | no next file with comments »