Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1047223002: MIPS: Fix assembler test for selection instructions to be run for r6 only. (Closed)

Created:
5 years, 8 months ago by dusmil.imgtec
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix assembler test for selection instructions to be run for r6 only. TEST=test-assembler-mips/MIPS16 BUG= Committed: https://crrev.com/eb982a1bb15b694ab8992ebe62c44ffa6ae9c50d Cr-Commit-Position: refs/heads/master@{#27556}

Patch Set 1 #

Patch Set 2 : Addressed comments in code and typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -155 lines) Patch
M test/cctest/test-assembler-mips.cc View 1 2 chunks +91 lines, -88 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 2 chunks +67 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dusmil.imgtec
5 years, 8 months ago (2015-03-31 17:34:32 UTC) #2
paul.l...
LGTM.
5 years, 8 months ago (2015-03-31 17:53:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047223002/20001
5 years, 8 months ago (2015-03-31 22:18:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 22:39:55 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 22:40:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb982a1bb15b694ab8992ebe62c44ffa6ae9c50d
Cr-Commit-Position: refs/heads/master@{#27556}

Powered by Google App Engine
This is Rietveld 408576698