Never force a max dialog height of less than 200 pixels

Never force a max dialog height of less than 200 pixels

Some dialogs liks chrome://settings/clearBrowserData and
chrome://settings/resetProfileSettings look really bad if the browser window
has a very small height. This CL ensures that the dialog can always occupy 200
vertical pixels.

BUG=329792
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243295

[battre, 2013-12-20 16:02:34]

Hi Evan,

could you please take a look whether you agree with this approach or whether you
would rather have it fixed in a different way.

The bug describes the problem. Another way to reproduce the bug is: Go to
chrome://settings/resetProfileSettings, make the window height very small (50
pixels) and scroll down. You will see that some controls are outside of the
boundary of the dialog area.

Best regards,
Dominic

[Evan Stade, 2013-12-20 21:48:08]

Are you sure there's no dialog for which a height <200px makes sense (or is even
preferable)?

https://codereview.chromium.org/104713012/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/overlay.js (right):

https://codereview.chromium.org/104713012/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/overlay.js:86: Math.min(Math.max(200, 0.9 *
window.innerHeight), 640) + 'px';
apparently, min-height beats max-height. So you could just set min-height to 200
maybe? (in some css file of course)

[Evan Stade, 2013-12-20 21:52:32]

hmmm, I take it back. Even with a height of 200px you get a pretty weird looking
dialog in this case. The problem is that the dialog should just never change
size. So for this one dialog, you need to set max-height: none. I guess the way
I'd recommend doing this is not max-height: none !important, but rather adding a
new css class that's called .not-resizable or something, and removing elements
with that class from the max-height query selector.

[battre, 2014-01-03 16:12:50]

Is this what you had in mind? It works well in my opinion.

[Evan Stade, 2014-01-03 22:39:04]

lgtm

[commit-bot: I haz the power, 2014-01-07 09:50:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/104713012/120001

[commit-bot: I haz the power, 2014-01-07 15:28:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/104713012/120001

[commit-bot: I haz the power, 2014-01-07 15:41:52]

Change committed as 243295