Issue 104713004: Add UseCounters for HTMLElement.innerText and .outerText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104713004: Add UseCounters for HTMLElement.innerText and .outerText (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews)

CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Add UseCounters for HTMLElement.innerText and .outerText There is no specification for this yet, and there's a chance that at least outerText is used little enough to be removed. All major engines except Gecko have some implementation: https://bugzilla.mozilla.org/show_bug.cgi?id=264412 BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163289

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	Source/core/frame/UseCounter.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/html/HTMLElement.idl	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

arv (Not doing code reviews)

LGTM innerText ins used a lot. Most people do not realize how bad it is ...

7 years ago (2013-12-05 18:52:04 UTC) #2

philipj_slow

On 2013/12/05 18:52:04, arv wrote: > LGTM > > innerText ins used a lot. Most ...

7 years ago (2013-12-05 19:57:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/104713004/1

7 years ago (2013-12-05 19:58:03 UTC) #4

Message was sent while issue was closed.

Change committed as 163289