Source/core/html/track/vtt/VTTCue.cpp - Issue 104713002: Use the return value to signal success for VTTParser helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 104713002: Use the return value to signal success for VTTParser helpers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Dropped unused constant Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/track/vtt/VTTCue.cpp

diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp

index 7006b00981ad87ecf720b28d0141c468e9f2bb13..0b8487f94f9234baac799cfb54e5067825c905d8 100644

--- a/Source/core/html/track/vtt/VTTCue.cpp

+++ b/Source/core/html/track/vtt/VTTCue.cpp

@@ -675,8 +675,8 @@ void VTTCue::markFutureAndPastNodes(ContainerNode* root, double previousTimestam

if (child->nodeName() == timestampTag) {

unsigned position = 0;

String timestamp = child->nodeValue();

- double currentTimestamp = VTTParser::collectTimeStamp(timestamp, &position);

- ASSERT(currentTimestamp != -1);

+ double currentTimestamp;

+ VTTParser::collectTimeStamp(timestamp, &position, currentTimestamp);

jochen (gone - plz use gerrit) 2013/12/05 09:00:36 why not ASSERT() around this call?

if (currentTimestamp > movieTime)

isPastNode = false;

« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTParser.h » ('j') | no next file with comments »