net/android/network_change_notifier_factory_android.cc - Issue 1047103002: Avoid initial NetworkChangeNotifier OnDNSChanged() signal on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/network_change_notifier_factory_android.cc

Issue 1047103002: Avoid initial NetworkChangeNotifier OnDNSChanged() signal on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert an accidental test enabling Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/android/network_change_notifier_factory_android.cc

diff --git a/net/android/network_change_notifier_factory_android.cc b/net/android/network_change_notifier_factory_android.cc

index 64b9ca2a21559f9f08e2bbe8d9da8c4ada12c069..329691829d2d0568cc76ecda276aae3256256aab 100644

--- a/net/android/network_change_notifier_factory_android.cc

+++ b/net/android/network_change_notifier_factory_android.cc

@@ -14,7 +14,7 @@ NetworkChangeNotifierFactoryAndroid::NetworkChangeNotifierFactoryAndroid() {}

NetworkChangeNotifierFactoryAndroid::~NetworkChangeNotifierFactoryAndroid() {}

NetworkChangeNotifier* NetworkChangeNotifierFactoryAndroid::CreateInstance() {

- return new NetworkChangeNotifierAndroid(&delegate_);

+ return new NetworkChangeNotifierAndroid(&delegate_, nullptr);

}

} // namespace net

« no previous file with comments | « net/android/network_change_notifier_android_unittest.cc ('k') | net/base/network_change_notifier.h » ('j') | no next file with comments »